Keep current Sequence No. for batch operations until SaveState is called and align GetNextNo events in new facade with GetNextNo events in NoSeriesManagement #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gn GetNextNo events in new facade with GetNextNo events in NoSeriesManagement
AndreasMoth
changed the title
grobyns
previously approved these changes
Feb 13, 2024
stkillen
approved these changes
Feb 13, 2024
JesperSchulz
approved these changes
Feb 13, 2024
AndreasMoth
deleted the
private/anmoth/PreventBatchingFromUpdatingSequences
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently NoSeriesManagement does not increment the sequence numbers if it's set to not modify the record, but it will still get new numbers. Hence aligning here with batching, if it's a temporary record we should also not update the database.
Furthermore I'm also aligning the events from NoSeriesManagement.GetNextNo to the new facade GetNextNo.
Fixes AB#471519